Add Popup UI for Web Push Subscription in Extension #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the cookbook.push example by introducing a popup.html and popup.js to provide a user-friendly interface for managing push subscriptions. It addresses Issue #1408 by ensuring a complete web push implementation with non-interactive subscription handling.
Additionally, this PR addresses the review feedback from PR #1410 by isolating and implementing the requested changes separately.
Changes Implemented:
popup.html & popup.js:
User Interface for Subscription Management:
Added a simple UI with "Subscribe" and "Unsubscribe" buttons.
Displays the current subscription status to the user.
Service Worker Integration:
Ensures the service worker is ready before attempting push subscription.
Handles both subscribing and unsubscribing from push notifications.
Enhanced Logging & Error Handling:
Provides clear console logs for debugging.
Displays subscription status updates directly in the popup.
background.js:
Integrated with popup.js to ensure smooth communication between the popup and service worker.
Improved push subscription flow by ensuring userVisibleOnly: true.
This update ensures a fully functional web push example with a proper UI, making it easier for users to subscribe/unsubscribe without requiring manual DevTools interactions.