Skip to content

Fix: Add 'No issues found' option to review status dropdown #4885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tiwaryfied
Copy link

This PR adds a new option, "No issues found", to client-src/elements/form-field-enums.ts to improve clarity in security and privacy review statuses.

This ensures that reviews where no issues are detected can be clearly marked, avoiding ambiguity between "Pending" and "Not applicable"

Copy link

google-cla bot commented Mar 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jrobbins
Copy link
Collaborator

I'm glad that you are getting familiar with our code. If you were to continue with this change, you would need to change both the client-side and the server-side.

However, I don't think that the review teams desire this change. They have been successfully using "Approved" for the situation in which a review was done and now issues were found. So, we are unlikely to merge this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants