report: remove insight audits from hidden group #16418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm... this was on purpose ... unclear how this works in the LH we just shipped to CDT but not via CLI. |
|
nvm https://github.com/GoogleChrome/lighthouse/pull/16391/files#diff-7fa506c4a89877e9bcc3873e5ed63a50977c31d704cbb19513d53c6f4ec77cdf is what makes this work in CDT for CLI, need to pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insight toggle button wasn't working because these were all marked hidden.
I see it works in DevTools right now, not sure how. But locally via CLI it wasn't working for me.