Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize the importance of proper event handling #573

Closed
wants to merge 1 commit into from
Closed

Emphasize the importance of proper event handling #573

wants to merge 1 commit into from

Conversation

mikep-dev
Copy link

This is a followup to the issue: #502

When batching, attaching a visibilitychange event listener to document can cause CLS data to be missed because CLS data is reported on visibilitychange event on document as well and depending on when event listeners were attached, sometimes data will be reported before or after batching.

This is very easy to miss and some users, including myself, overlooked this (e.g. #500). This PR adds a much needed clarification.

Copy link

google-cla bot commented Dec 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mikep-dev mikep-dev closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant