Skip to content

HTTP Layer for Update Saved Search #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2025
Merged

HTTP Layer for Update Saved Search #1351

merged 3 commits into from
Apr 2, 2025

Conversation

jcscottiii
Copy link
Collaborator

@jcscottiii jcscottiii commented Mar 31, 2025 •
edited
Loading

This adds the HTTP layer for the update saved search operation.

Validation changes:

  • Refactor the validation logic of SavedSearches so that CreateSavedSearch and UpdateSavedSearch
    can both use the same logic.
  • The update saved search validation contains additional checks for the update_mask passed in.

Other changes:

  • Add 404 case for update saved search in the openapi document

@jcscottiii jcscottiii force-pushed the jcscottiii/ui-searches-v6.0.3.1 branch 2 times, most recently from fe2e8e3 to 810f6a7 Compare April 1, 2025 18:47
@jcscottiii jcscottiii force-pushed the jcscottiii/ui-searches-v6.0.3.2 branch from 0a7f854 to 475c1bb Compare April 1, 2025 18:52
Base automatically changed from jcscottiii/ui-searches-v6.0.3.1 to main April 1, 2025 20:31
@jcscottiii jcscottiii force-pushed the jcscottiii/ui-searches-v6.0.3.2 branch from 1e8f70a to 8c140ca Compare April 1, 2025 20:39
@jcscottiii
HTTP Layer for Update Saved Search
eddf7d6 
This adds the HTTP layer for the update saved search operation.

Validation changes:
- Refactor the validation logic of SavedSearches so that CreateSavedSearch and UpdateSavedSearch
  can both use the same logic.
- The update saved search validation contains additional checks for the update_mask passed in.

Other changes:
- Add 404 case for update saved search in the openapi document
@jcscottiii jcscottiii force-pushed the jcscottiii/ui-searches-v6.0.3.2 branch from 8c140ca to eddf7d6 Compare April 1, 2025 20:59
@jcscottiii jcscottiii marked this pull request as ready for review April 1, 2025 21:35
@jcscottiii jcscottiii requested review from jrobbins and KyleJu April 1, 2025 21:35
KyleJu
KyleJu approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@KyleJu KyleJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with optional nits

@jcscottiii jcscottiii enabled auto-merge April 1, 2025 23:53
@jcscottiii jcscottiii added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit 80e7bcc Apr 2, 2025
6 checks passed
@jcscottiii jcscottiii deleted the jcscottiii/ui-searches-v6.0.3.2 branch April 2, 2025 00:26
@jrobbins jrobbins mentioned this pull request Apr 2, 2025
Closed
@jcscottiii jcscottiii linked an issue Apr 14, 2025 that may be closed by this pull request
[ENHANCEMENT] Backend has piping to update saved searches #1347
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleJu KyleJu KyleJu approved these changes

@jrobbins jrobbins Awaiting requested review from jrobbins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Backend has piping to update saved searches
2 participants
@jcscottiii @KyleJu