Add checks for the number of bookmarks and prevent removal of owned searches #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earches. Change 1: Limit number of bookmarks We already have a limit for the number of saved searches a user can own. This code adds a new configuration for the number of bookmarks they can have. In addition to the 25 saved searches they can own, they also can bookmark 25 other saved searches that they don't own. Change 2: Prevent bookmark removal of owned searches When a user creates a saved search, they are automatically bookmarked (Similar to [issue tracker](https://developers.google.com/issue-tracker/guides/work-with-hotlist#:~:text=Hotlists%20that%20you%20own%20are%20starred%20automatically)). And in Issue Tracker, you can't remove the star if you are the admin. This change adds the same type of check.
jrobbins
approved these changes
Apr 2, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 1: Limit number of bookmarks
We already have a limit for the number of saved searches a user can own.
This code adds a new configuration for the number of bookmarks they can have.
In addition to the 25 saved searches they can own, they also can bookmark 25 other saved searches that they don't own.
Change 2: Prevent bookmark removal of owned searches
When a user creates a saved search, they are automatically bookmarked (Similar to issue tracker).
And in Issue Tracker, you can't remove the star if you are the admin. This change adds the same type of check.