Add adapter logic to handle bookmark operations #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
force-pushed
the
jcscottiii/saved-searches-v7.0.2
branch
from
c6faabe to
472f893
Compare
jrobbins
approved these changes
Apr 2, 2025
jcscottiii
force-pushed
the
jcscottiii/saved-searches-v7.0.1
branch
from
14313a7 to
cb66728
Compare
jcscottiii
force-pushed
the
jcscottiii/saved-searches-v7.0.2
branch
from
472f893 to
af1a053
Compare
This change adds the adapter logic for the putUserSavedSearchBookmark and removeUserSavedSearchBookmark operations. putUserSavedSearchBookmark handles converting the errors from spanner for 1) bookmark limit exceeded and 2) entity does not exist to errors that the http layer will use to return the appropriate status code removeUserSavedSearchBookmark handles converting the errors from spanner for 1) saved search owner cannot delete bookmark and 2) entity does not exist to errors that the http layer will use to return the appropriate status code
jcscottiii
force-pushed
the
jcscottiii/saved-searches-v7.0.2
branch
from
af1a053 to
fccfae8
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the adapter logic for the putUserSavedSearchBookmark and removeUserSavedSearchBookmark operations.
PutUserSavedSearchBookmark handles converting the errors from spanner for 1) bookmark limit exceeded and 2) entity does not exist to errors that the http layer will use to return the appropriate status code
RemoveUserSavedSearchBookmark handles converting the errors from spanner for 1) saved search owner cannot delete bookmark and 2) entity does not exist to errors that the http layer will use to return the appropriate status code