Skip to content

Redo config and customization #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2025

Conversation

owtaylor
Copy link

@owtaylor owtaylor commented Apr 1, 2025

A grab-bag of changes to get us back to a similar state after merging the new UI

  • Merge our configuration into config.yaml, not config.json; config.json is now entirely ignored
  • Update our granite configuration to not set parameters that don't matter with T=0 (top_p, top_k) and not set frequencyPenalty: 0.1 which is no longer supported in config.yaml - where that came from is unclear, and there's no standard recommendation to use it with Granite.
  • Hide model selection and assistant selection dropdowns unless there is more than one model/assistant
  • Remove the "New Assistant" button that takes you to hub.continue.dev
  • Tweak adding chat models so that it can be done from the models section of the new "lump toolbar"
  • Don't auto-add transformers.js embedding model - we don't need it

This roughly corresponds to a discussion I had with @allanday about how we should adjust to the new UI

owtaylor added 5 commits April 1, 2025 16:10
When loading ~/.granite-code/config.yaml or
~/granite.code/assistants/*.yaml, add our models and the default context
providers to the config.
Having the extra transformers.js embedding model around confuses
selection; since there is supposed to be a local Ollama for our
operation, using that for embeddings will probably provide better
performance in any case.
Rather than take the user to config.yaml, pop up the "Add Models" form
that you would normally get from the bottom of the model model
menu (we're removing the option from that menu, and will hide the menu entirely
unless there is more than one chat model available)
…owns

Model selection:
 - Don't show unless more than one model
 - Remove the "Add chat model" option - you can get to that from the
   model section of the lump toolbar.

Assistant selection:
 - Don't show unless than more than one model
 - Remove the "New Assistant" option, which takes you to
   hub.continue.dev; local assistants can be created by manually
   adding files within ~/.granite-code/assistants/.
Since we no longer have code to merge our config into config.json,
just ignore config.json files - trying to support the legacy
config file format for Continue doesn't make sense.
@fbricon
Copy link

fbricon commented Apr 3, 2025

looks like this restores the tools icon
Screenshot 2025-04-03 at 10 09 48

Update: I don't understand what I did wrong but I was obviously not running the proper branch. It looks fine actually

@fbricon
Copy link

fbricon commented Apr 3, 2025

We should prolly hide the rerank selector:

Screenshot 2025-04-03 at 14 51 29

@fbricon
Copy link

fbricon commented Apr 3, 2025

ok so after I finally got the proper build working, we can ignore my last comment. As discussed with @owtaylor, there are a couple issues to address, but I think it's fine to merge this PR first and address them in a follow up, as it would make the base branch usable again.

things to address next:

  • remove the tools/agent elements from UI
  • prevent users from adding a new model from the models section
  • a "Create your first assistant" elements briefly (< 1s) shows up when the view is loaded

@fbricon fbricon merged commit 4c9a987 into granite/customization Apr 4, 2025
21 of 25 checks passed
@fbricon fbricon mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants