LAGraph v1.2

.github/workflows/build-arch-emu.yaml

@@ -0,0 +1,91 @@
+name: arch-emu
+
+# FIXME: do this on workflow_dispatch only
+on:
+  workflow_dispatch:
+  push:
+    branches-ignore:
+      - '**/v1.2'
+  pull_request:
+
+jobs:
+
+  alpine:
+    # Run armv7 on aarch64 runners
+    runs-on: ${{ matrix.arch == 'armv7' && 'ubuntu-24.04-arm' || 'ubuntu-latest' }}
+
+    defaults:
+      run:
+        # Use emulated shell as default
+        shell: alpine.sh {0}
+
+    strategy:
+      matrix:
+        config:
+          # FIXME: switch to 10.1.0 when it is released:
+         - {grb_version: 10.0.5}
+        # For available CPU architectures, see:
+        # https://github.com/marketplace/actions/setup-alpine-linux-environment
+        arch: [riscv64]
+        include:
+          - arch: riscv64
+            ccache-max: 28M
+
+    name: alpine (${{ matrix.arch }})
+
+    steps:
+      - name: get CPU information (host)
+        shell: bash
+        run: lscpu
+
+      - name: checkout repository
+        uses: actions/checkout@v4
+        # shell: bash
+
+      - name: install dependencies
+        uses: jirutka/setup-alpine@v1
+        # shell: bash
+        with:
+          arch: ${{ matrix.arch }}
+          apk-tools-url: ${{ matrix.arch == 'armv7'
+              && 'https://gitlab.alpinelinux.org/api/v4/projects/5/packages/generic/v2.14.7/aarch64/apk.static#!sha256!27a975638ddc95a411c9f17c63383e335da9edf6bb7de2281d950c291a11f878'
+              || 'https://gitlab.alpinelinux.org/api/v4/projects/5/packages/generic/v2.14.7/x86_64/apk.static#!sha256!bdd044e0fd6cc388c5e571e1093efa5f35f7767cc5aa338b0a2576a429009a62' }}
+          packages: >
+            build-base
+            ccache
+            cmake
+            lscpu
+            libtool
+            git
+            sudo
+
+      - name: disable QEMU emulation
+        if: matrix.arch == 'armv7'
+        shell: bash
+        run: sudo update-binfmts --disable qemu-arm
+
+      - name: get CPU information (emulated)
+        run: lscpu
+
+      - name: build GraphBLAS
+        run: |
+          echo "gcc --version"
+          gcc --version
+          echo "gcc -dumpmachine"
+          gcc -dumpmachine
+          git clone https://github.com/DrTimothyAldenDavis/GraphBLAS.git
+          cd GraphBLAS
+          # FIXME: switch to 10.1.0 when it is released:
+          # git checkout tags/v${{ matrix.config.grb_version }}
+          git checkout dev2
+          make compact
+          sudo make install
+          cd ..
+
+      - name: build and test LAGraph
+        run: |
+          cd build
+          cmake ..
+          JOBS=2 make
+          ctest . --verbose
+

.github/workflows/build.yml

@@ -8,20 +8,28 @@ on:
   pull_request:
 
 jobs:
+
   linux:
+
     runs-on: ubuntu-22.04
+
     strategy:
       matrix:
         config:
         # if there are multiple items in this list, only use should
         # deployit=true for just one of them.
-         - {grb_version: 9.3.1, deployit: true}
+         - {grb_version: 9.0.0, deployit: false}
+         - {grb_version: 10.0.3, deployit: true}
+
     steps:
+
     - name: Checkout
       uses: actions/[email protected]
+
     - name: Install tools for build
       run: |
         sudo apt install -y lcov
+
     - name: Build GraphBLAS
       run: |
         git clone https://github.com/DrTimothyAldenDavis/GraphBLAS.git
@@ -30,40 +38,50 @@ jobs:
         make compact
         sudo make install
         cd ..
+
     - name: Build project
       run: |
-        export GRAPHBLAS_INCLUDE_DIR=`pwd`/GraphBLAS/include/suitesparse
-        export GRAPHBLAS_LIBRARY=`pwd`/GraphBLAS/lib/libgraphblas.so
         cd build
-        cmake .. -DCOVERAGE=1 -DGRAPHBLAS_INCLUDE_DIR=${GRAPHBLAS_INCLUDE_DIR} -DGRAPHBLAS_LIBRARY=${GRAPHBLAS_LIBRARY}
+        cmake .. -DCOVERAGE=1
         JOBS=2 make
         make test_coverage
+
     - name: Deploy
       uses: JamesIves/[email protected]
       if: matrix.config.deployit && github.event_name == 'push' && github.ref == 'refs/heads/stable'
       with:
         branch: gh-pages
         folder: build/test_coverage/
         single-commit: true
+
     - name: Save output
       uses: actions/[email protected]
+      if: matrix.config.deployit
       with:
         name: test_coverage
         path: build/test_coverage/
+
   macos:
+
     runs-on: macos-14
+
     strategy:
       matrix:
         config:
-         - {grb_version: 9.3.1}
+         - {grb_version: 9.0.0}
+         - {grb_version: 10.0.3}
+
     steps:
+
     - name: Checkout
       uses: actions/[email protected]
+
     - name: Install dependencies
       run: |
         brew tap-new libomp/cask
         brew extract --version=14.0.6 libomp libomp/cask
         brew install [email protected]
+
     - name: Build GraphBLAS
       run: |
         git clone https://github.com/DrTimothyAldenDavis/GraphBLAS.git
@@ -72,13 +90,13 @@ jobs:
         make compact
         sudo make install
         cd ..
+
     - name: Build project
       run: |
-        export GRAPHBLAS_INCLUDE_DIR=`pwd`/GraphBLAS/include/suitesparse
-        export GRAPHBLAS_LIBRARY=`pwd`/GraphBLAS/lib/libgraphblas.dylib
         # adding an extra line to the CMakeLists.txt file to locate the libomp instance installed by brew
         echo 'include_directories("/usr/local/opt/libomp/include")' | cat - CMakeLists.txt
         cd build
-        CC=gcc cmake .. -DGRAPHBLAS_INCLUDE_DIR=${GRAPHBLAS_INCLUDE_DIR} -DGRAPHBLAS_LIBRARY=${GRAPHBLAS_LIBRARY}
+        cmake ..
         JOBS=2 make
-        make test
+        ctest .
+

.gitignore

@@ -41,6 +41,8 @@ gmon.out
 cmake-build-debug*
 CMakeFiles*
 *~
+data/comments*.txt
+data/comments*.mtx
 
 */build/*
 **/.venv/*

.readthedocs.yaml

@@ -2,11 +2,6 @@
 
 version: 2
 
-build:
-  os: ubuntu-22.04
-  tools:
-    python: "3.12"
-
 formats:
   - pdf
 

CMakeLists.txt

@@ -39,10 +39,10 @@
 cmake_minimum_required ( VERSION 3.20 ) # LAGraph can be built stand-alone
 
 # version of LAGraph
-set ( LAGraph_DATE "Feb 20, 2025" )
+set ( LAGraph_DATE "FIXME, 2025" )
 set ( LAGraph_VERSION_MAJOR 1 CACHE STRING "" FORCE )
-set ( LAGraph_VERSION_MINOR 1 CACHE STRING "" FORCE )
-set ( LAGraph_VERSION_SUB   5 CACHE STRING "" FORCE )
+set ( LAGraph_VERSION_MINOR 2 CACHE STRING "" FORCE )
+set ( LAGraph_VERSION_SUB   0 CACHE STRING "" FORCE )
 
 message ( STATUS "Building LAGraph version: v"
     ${LAGraph_VERSION_MAJOR}.
@@ -127,6 +127,7 @@ endif ( )
 
 if ( SUITESPARSE_ROOT_CMAKELISTS )
 
+    message ( STATUS "Looking for GraphBLAS in SuiteSparse" )
     if ( TARGET GraphBLAS )
         add_library ( GraphBLAS::GraphBLAS ALIAS GraphBLAS )
     else ( )
@@ -153,6 +154,7 @@ else ( )
     # No package version is explicitly stated here; an arbitrary GraphBLAS
     # library can have any version number.  For SuiteSparse:GraphBLAS, LAGraph
     # requires v7.1.0 or later, which is checked in LAGraph.h.
+    message ( STATUS "Looking for GraphBLAS with FindGraphBLAS.cmake" )
     find_package ( GraphBLAS MODULE REQUIRED )
 
 endif ( )
@@ -219,6 +221,7 @@ message ( STATUS "CMAKE have OpenMP:         " ${OPENMP_C_FOUND} )
 
 include_directories ( ${PROJECT_SOURCE_DIR}/include
                       ${PROJECT_SOURCE_DIR}/src/utility
+                      ${PROJECT_SOURCE_DIR}/src/algorithm
                       ${PROJECT_SOURCE_DIR}/test/include )
 
 # tell LAGraph where to find its own source (for LAGraph/data files)
@@ -247,6 +250,10 @@ elseif ( "${CMAKE_C_COMPILER_ID}" STREQUAL "Intel" )
     #if ( CMAKE_C_COMPILER_VERSION VERSION_LESS 18.0 )
     #    message ( FATAL_ERROR "icc version must be at least 18.0" )
     #endif ( )
+elseif ( "${CMAKE_C_COMPILER_ID}" STREQUAL "AppleClang" )
+    # options for Apple Clang
+#    set ( CMAKE_C_FLAGS  "${CMAKE_C_FLAGS} -fsanitize=address" )
+#    set ( CMAKE_C_FLAGS  "${CMAKE_C_FLAGS} -fsanitize=thread" )
 elseif ( "${CMAKE_C_COMPILER_ID}" STREQUAL "Clang" AND NOT "${CMAKE_C_COMPILER_FRONTEND_VARIANT}" STREQUAL "MSVC" )
     # options for clang
     set ( CMAKE_C_FLAGS  "${CMAKE_C_FLAGS} -O3 " )
@@ -287,6 +294,7 @@ message ( STATUS "CMAKE C flags: " ${CMAKE_C_FLAGS} )
 # enable testing and add subdirectories
 #-------------------------------------------------------------------------------
 
+set ( MEMORYCHECK_COMMAND_OPTIONS "--show-reachable=no" )
 include ( CTest )
 
 add_subdirectory ( src )
@@ -317,6 +325,31 @@ if ( BUILD_STATIC_LIBS )
         PUBLIC_HEADER DESTINATION ${SUITESPARSE_INCLUDEDIR} )
 endif ( )
 
+#-------------------------------------------------------------------------------
+# LAGraph uses OpenMP by default
+#-------------------------------------------------------------------------------
+
+if ( LAGRAPH_HAS_OPENMP )
+    message ( STATUS "CMAKE OpenMP libraries:    ${OpenMP_C_LIBRARIES}" )
+    message ( STATUS "CMAKE OpenMP include:      ${OpenMP_C_INCLUDE_DIRS}" )
+    if ( BUILD_SHARED_LIBS )
+        target_link_libraries ( LAGraph PRIVATE OpenMP::OpenMP_C )
+    endif ( )
+    if ( BUILD_STATIC_LIBS )
+        target_link_libraries ( LAGraph_static PRIVATE OpenMP::OpenMP_C )
+    endif ( )
+    message ( STATUS "CMAKE OpenMP C flags:      ${OpenMP_C_FLAGS}" )
+else ( )
+    if ( NOT COVERAGE )
+        message ( WARNING
+        "WARNING:  OpenMP was not found (or was disabled with "
+        "LAGRAPH_USE_OPENMP; some LAGraph methods will be slow.)" )
+    endif ( )
+endif ( )
+
+#-------------------------------------------------------------------------------
+# LAGraph targets and package configuration
+#-------------------------------------------------------------------------------
 
 # create (temporary) export target file during build
 export ( EXPORT LAGraphTargets
@@ -424,3 +457,4 @@ if ( NOT MSVC )
         ${CMAKE_CURRENT_BINARY_DIR}/LAGraph.pc
         DESTINATION ${SUITESPARSE_PKGFILEDIR}/pkgconfig )
 endif ( )
+

ChangeLog

@@ -1,3 +1,10 @@
+Version 1.2.0:  in progress
+
+    * v2.1 C API: using the new GrB_get/set methods in the C API;
+        LAGraph can now use a "vanilla" GraphBLAS that supports the v2.1
+        C API.  If SuiteSparse:GraphBLAS is used, v9.0.0 is required.
+
+
 Feb 20, 2025: version 1.1.5
 
     * minor updates to github CI

Contributors.txt

@@ -5,27 +5,40 @@ this project.
 
 Contributors (in alphabetical order):
 
-    Janos B. Antal,    Budapest University of Technology and Economics, Hungary
-    Mohsen Aznaveh,    Texas A&M University
-    David A. Bader     New Jersey Institute of Technology
-    Aydin Buluc,       Lawrence Berkeley National Lab
-    Jinhao Chen,       Texas A&M University
-    Tim Davis,         Texas A&M University
-    Florentin Dorre,   Technische Univeritat Dresden, Neo4j
-    Marton Elekes,     Budapest University of Technology and Economics, Hungary
-    Balint Hegyi,      Budapest University of Technology and Economics, Hungary
-    Tanner Hoke,       Texas A&M University
-    James Kitchen,     Anaconda
-    Scott Kolodziej,   Texas A&M University
-    Pranav Konduri,    Texas A&M University
-    Roi Lipman,        Redis Labs
-    Tze Meng Low,      Carnegie Mellon University
-    Tim Mattson,       Intel
-    Scott McMillan,    Carnegie Mellon University
-    Markus Muetzel,
-    Michel Pelletier,  Graphegon
-    Gabor Szarnyas,    CWI Amsterdam, The Netherlands
-    Erik Welch,        Anaconda, NVIDIA
-    Carl Yang,         University of California at Davis, Waymo
-    Yongzhe Zhang,     SOKENDAI, Japan
+    Janos B. Antal      Budapest University of Technology and Economics, Hungary
+    Mohsen Aznaveh      Texas A&M University
+    David A. Bader      New Jersey Institute of Technology
+    Georgiy Belyanin    St. Petersburg State University
+    Aydin Buluc         Lawrence Berkeley National Lab
+    Jinhao Chen         Texas A&M University
+    Tim Davis           Texas A&M University
+    Florentin Dorre     Technische Univeritat Dresden, Neo4j
+    Marton Elekes       Budapest University of Technology and Economics, Hungary
+    Alexandra Goff      Texas A&M University
+    Gabriel Gomez       Texas A&M University
+    Semyon Grigoriev    St. Petersburg State University
+    Balint Hegyi        Budapest University of Technology and Economics, Hungary
+    Tanner Hoke         Texas A&M University
+    James Kitchen       Anaconda
+    Scott Kolodziej     Texas A&M University
+    Ilhom Kombaev       St. Petersburg State University
+    Pranav Konduri      Texas A&M University
+    Christina Koutsou   Aristotle University of Thessaloniki
+    Roi Lipman          Redis Labs
+    Tze Meng Low        Carnegie Mellon University
+    Vidith Madhu        Texas A&M University
+    Tim Mattson         Intel
+    Scott McMillan      Carnegie Mellon University
+    Markus Muetzel
+    Hemanth Mukesh      Texas A&M University
+    Olumayowa Olowomeye Texas A&M University
+    Casey Pei           Texas A&M University
+    Michel Pelletier    Graphegon, OneSparse
+    Darin Peries        Texas A&M University
+    Cameron Quilici     Texas A&M University
+    Aurko Routh         Texas A&M University
+    Gabor Szarnyas      CWI Amsterdam, The Netherlands
+    Erik Welch          Anaconda, then NVIDIA
+    Carl Yang           University of California at Davis, Waymo
+    Yongzhe Zhang       SOKENDAI, Japan
 

Makefile

@@ -76,6 +76,14 @@ test: library
 verbose_test: library
 	( cd build && ctest . --verbose || ctest . --rerun-failed --output-on-failure )
 
+# memcheck: compile with -g and no OpenMP (the latter gives spurious leaks from
+# dlopen and dlinit), and run the tests with valgrind.  For best results,
+# compile GraphBLAS without OpenMP and with the JIT disabled.
+memcheck: distclean
+	( cd build && cmake $(CMAKE_OPTIONS) -DCMAKE_BUILD_TYPE=Debug -DLAGRAPH_USE_OPENMP=0 .. )
+	( cd build && cmake --build . --config Release -j${JOBS} )
+	( cd build && ctest . -T memcheck )
+
 # target used in CI
 demos: test