-
Notifications
You must be signed in to change notification settings - Fork 4
implement tensors in binsparse #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
TODO: you need to apparently set the format key.
@BenBrock Here's the PR to add tensors to the spec, please review when you get the chance! |
@junikimm717 @willow-ahrens Thanks for submitting the PR! At first glance everything looks generally good. I see two small problems:
I would also prefer to add a new flag I'm also happy to fix these issues myself, but I have a busy week with a deadline coming up, so I probably won't be able to spend time on this until next week. |
Currently, the tensor tests only run if Julia is installed. Is this sufficient? |
Yes, requiring Julia for the tensor tests is fine for now, as long as we can run the CI in GitHub actions. (That should be no problem.) |
bsp_tensor_t
field is returned.