Skip to content

implement tensors in binsparse #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

junikimm717
Copy link

  • a separate bsp_tensor_t field is returned.

@willow-ahrens
Copy link

@BenBrock Here's the PR to add tensors to the spec, please review when you get the chance!

@BenBrock
Copy link
Contributor

BenBrock commented Apr 7, 2025

@junikimm717 @willow-ahrens Thanks for submitting the PR! At first glance everything looks generally good. I see two small problems:

  1. Missing SPDX headers on some of the new files (see example here)
  2. Incorrect path in testing infrastructure (see CI error here.).

I would also prefer to add a new flag ENABLE_TENSOR_TESTS or something like that to enable/disable the new tests (since they require Julia as an external dependency).

I'm also happy to fix these issues myself, but I have a busy week with a deadline coming up, so I probably won't be able to spend time on this until next week.

@willow-ahrens
Copy link

Currently, the tensor tests only run if Julia is installed. Is this sufficient?

@BenBrock
Copy link
Contributor

Yes, requiring Julia for the tensor tests is fine for now, as long as we can run the CI in GitHub actions. (That should be no problem.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants