Skip to content

Invalidate cache when unexposing input #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2025
Merged

Invalidate cache when unexposing input #2512

merged 2 commits into from
Apr 13, 2025

Conversation

c-mateo
Copy link
Contributor

@c-mateo c-mateo commented Apr 3, 2025

Fixes #2493 adding NodeGraphMessage::RunDocumentGraph to the list of responses for NodeGraphMessage::ExposeInput in the node_graph_message_handler.rs file.

@c-mateo c-mateo mentioned this pull request Apr 3, 2025
Closed
@Keavon Keavon requested a review from 0HyperCube April 3, 2025 23:03
@Keavon Keavon force-pushed the master branch 3 times, most recently from aa7ff13 to e11b57a Compare April 6, 2025 11:41
0HyperCube
0HyperCube approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@0HyperCube 0HyperCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for the fix.

@0HyperCube 0HyperCube enabled auto-merge (squash) April 13, 2025 19:07
@0HyperCube 0HyperCube merged commit 6bc12c8 into GraphiteEditor:master Apr 13, 2025
4 checks passed
@c-mateo c-mateo deleted the 2493-unexposing-input-invalidate-cache branch April 13, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0HyperCube 0HyperCube 0HyperCube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexposing an input doesn't immediately invalidate the cache
2 participants
@c-mateo @0HyperCube