Add Spline tool test for drawing with PTZ applied to the canvas view #2573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0HyperCube PTAL! |
Keavon
changed the title
0HyperCube
requested changes
Apr 16, 2025
|
@0HyperCube Resolved all the comments and applied all the feedback, Please have a look! |
|
@0HyperCube PTAL! |
…e into spline-tests-PTZ
|
@0HyperCube PTAL! |
0HyperCube
approved these changes
Apr 24, 2025
| editor.handle_message(NavigationMessage::CanvasPan { delta: DVec2::new(100., 50.) }).await; | ||
| editor | ||
| .handle_message(NavigationMessage::CanvasTiltSet { | ||
| angle_radians: (30. as f64).to_radians(), |
There was a problem hiding this comment.
You can just write 30_f64.to_radians(). However it doesn't really matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes a part of #2483
This pull request introduces new tests for the spline tool. These tests ensure that the spline tool works correctly under various transformations such as zooming, panning, and tilting the view.