Skip to content

Clean up API decorations in H5api_adpt.h #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2025
Merged

Clean up API decorations in H5api_adpt.h #5511

merged 4 commits into from
May 6, 2025

Conversation

derobins
Copy link
Member

@derobins derobins commented May 4, 2025 •
edited
Loading

Reduces duplication in H5api_adpt.h

Some API decorations (used to hide __declspec on Windows, among other
things) have been renamed to be consistent and easier to read:

H5_DLLCPP(VAR)           --> H5CPP_DLL(VAR)
H5_HLDLL(VAR)            --> H5HL_DLL(VAR)
H5_HLCPPDLL(VAR)         --> H5CPP_HL_DLL(VAR)
H5_FCDLL(VAR)            --> H5FC_DLL(VAR)
H5_FCTESTDLL(VAR)        --> H5FC_TEST_DLL(VAR)
HDF5_HL_F90CSTUBDLL(VAR) --> H5FC_HL_DLL(VAR)

Fixes #5509

derobins added 2 commits May 4, 2025 04:46
@derobins
Simplify H5api_adpt.h
25ab4f6 
This change also uses the shared markup (e.g., __declspec) in both
static and shared libraries as the shared markup is ignored when
building static libs.
@derobins
Renamed some API decorations
8357fc0 
Some API decorations (used to hide __declspec on Windows, among other
things) have been renamed:

    H5_DLLCPP(VAR)           --> H5CPP_DLL(VAR)
    H5_HLDLL(VAR)            --> H5HL_DLL(VAR)
    H5_HLCPPDLL(VAR)         --> H5CPP_HL_DLL(VAR)
    H5_FCDLL(VAR)            --> H5FC_DLL(VAR)
    H5_FCTESTDLL(VAR)        --> H5FC_TEST_DLL(VAR)
    HDF5_HL_F90CSTUBDLL(VAR) --> H5FC_HL_DLL(VAR)

The shared library decorations are also now used when building static
libraries (where they are meaningless and ignored).
qkoziol
qkoziol approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator

@qkoziol qkoziol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

brtnfld
brtnfld approved these changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lrknox lrknox merged commit 07e995d into HDFGroup:develop May 6, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyoklee hyoklee hyoklee approved these changes

@qkoziol qkoziol qkoziol approved these changes

@brtnfld brtnfld brtnfld approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@epourmal epourmal Awaiting requested review from epourmal epourmal is a code owner

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify the API macros in H5api_adpt.h
6 participants
@derobins @hyoklee @qkoziol @brtnfld @byrnHDF @lrknox