Skip to content

build: fix i386 openbsd-7.7 threads link error #5512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

build: fix i386 openbsd-7.7 threads link error #5512

wants to merge 2 commits into from

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented May 4, 2025 •
edited
Loading

byrnHDF
byrnHDF requested changes May 5, 2025
View reviewed changes
Copy link
Contributor

@byrnHDF byrnHDF left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are problems with the HDF5_ENABLE_THREADS option - it is used improperly

byrnHDF
byrnHDF reviewed May 5, 2025
View reviewed changes
CMakeLists.txt
@@ -799,35 +799,37 @@ endif ()

# Determine if a threading package is available on this system
option (HDF5_ENABLE_THREADS "Enable thread support" ON)
Copy link
Contributor

@byrnHDF byrnHDF May 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option should be removed

Then in src/CMakeLists.txt should remove the generator expressions involving the option.
Also other options should not use the state of options to forces defines.
Also there should probably be a line that adds the Threads::Threads library either to the link_libs variable or a new threads_lib variable

@hyoklee hyoklee closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF requested changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HDF5_ENABLE_THREADS:BOOL=OFF causes build failure
2 participants
@hyoklee @byrnHDF