Rework test file filtering #5552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
added
Priority - 2. Medium
mattjala
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler and
glennsong09
as code owners
byrnHDF
approved these changes
May 28, 2025
lrknox
approved these changes
May 30, 2025
github-project-automation
bot
moved this from In progress
to Done
in HDF5 - TRIAGE & TRACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test-time filters applied to output and reference files are now applied to copies of those files, leaving the original versions untouched.
Create the FILTER_FILE macro to factor out repeated work of applying a series of regex replacements to a file
Removed the TEST_MASK filter, since its function of deleting any expression matches can also be accomplished by TEST_FILTER when no value is provided for TEST_FILTER_REPLACE.
Removed TEST_MASK_STORE and TEST_MASK_MOD arguments. Storage/modification masking is now performed for all test files.
TEST_FILTER and TEST_FILTER_REPLACE arguments to runTest can now receives a semicolon-separated list of filter/replace expressions.
There is overlap between the changes here and in #5473, many of which were removed during the runTest rework.