FlxMatrixSprite #3427
Open
FlxMatrixSprite #3427
+105
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticing since this has some code based on my pr, skewDegress seems to have incorrect ordered parameters in docs and also seems to pass in the wrong arguments to skewRadians, not sure how I fumbled that lol |
Geokureli
commented
Apr 30, 2025
| */ | ||
| public inline function skewDegrees(skewX:Float, skewY:Float):FlxMatrix | ||
| { | ||
| return skewRadians(skewY * FlxAngle.TO_RAD, skewX * FlxAngle.TO_RAD); |
There was a problem hiding this comment.
These are flipped
Suggested change
| return skewRadians(skewY * FlxAngle.TO_RAD, skewX * FlxAngle.TO_RAD); | |
| return skewRadians(skewX * FlxAngle.TO_RAD, skewY * FlxAngle.TO_RAD); |
Comment on lines
+25
to
+29
| b = Math.tan(skewY); | ||
|
|
||
| c = Math.tan(skewX); | ||
|
|
||
| return this; |
There was a problem hiding this comment.
@DetectiveBaldi these are flipped too, right?
Suggested change
| b = Math.tan(skewY); | |
| c = Math.tan(skewX); | |
| return this; | |
| b = Math.tan(skewX); | |
| c = Math.tan(skewY); | |
| return this; |
There was a problem hiding this comment.
From what I can tell this is intended as intended, the same behavior can be seen in the original FlxSkewedSprite class:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Alternative to #3241