feat: keep rust-managed code block venvs separate #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Mitchell <[email protected]>
Signed-off-by: Nick Mitchell <[email protected]>
Signed-off-by: Nick Mitchell <[email protected]>
Signed-off-by: Nick Mitchell <[email protected]>
Signed-off-by: Nick Mitchell <[email protected]>
Signed-off-by: Nick Mitchell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
DO NOT MERGE, depends on #752 being merged first.
Refines #752 to use a separate venv for every distinct codeblock requirements… and that updates the pdl AST so that it transparently launches the python code using that venv.
This requires extending
CodeBlockso that the code field, forlang: commandcan be an array — i.e. an argv array. Currently it’s a string, meaning thatcall_command()needs to resort to ashlex.split(" ")which is problematic w.r.t. nested quotes.For example, if i have a CodeBlock with code that contains jinja variable expansions that expand to include single quotes… it is difficult in general to construct a string command line that works. whereas if i could provide an args array, this problem goes away.