Add a new retry feature to block

[hirokuni-kitahara]

Signed-off-by: hirokuni-kitahara [email protected]

This PR is based on the issue #823 and it adds two new fields retry_on_error and retry_max to the existing repeat block.
retry_on_error is a simple boolean value which indicates if the retry feature is enabled or not, and if true, errors while running the repeat block are added to the background context of the LLM.
retry_max is an integer value of the number of maximum retry.
This PR contains the following changes

• Update to the RepeatBlock model in pdl_ast.py
• Update while loop for repeat block in pdl_interpreter.py
• Update to the schema.json

[vazirim]

Hi @hirokuni-kitahara, the PR looks great. How about instead of adding 2 new fields we only have retry_max, set to 0 by default. When it's set to 0 it means that retry_on_error == False. When it's set to anything strictly greater than 0, then it's equivalent to retry_on_error == True with that number of max tries. wdyt?

When you make changes to the AST, you can run:

pdl --schema > src/pdl/pdl-schema.json

to automatically regenerate the jsonschema. This is probabaly what you did, but just double checking.

There are also some other files that need to change (with an AST change):
pdl_dumper.py
pdl_ast_utils.py

Finally, you can run the following locally to make sure everything is in good shape:

pytest

and:

pre-commit run --all-files

See the contribution docs
Thank you so much!

[hirokuni-kitahara]

Thank you for your feedback @vazirim !
I have updated the codes so that it uses retry_max for the feature flag and I removed retry_on_error based on your suggestion.
Also, I followed the steps in the contribution doc and now all checks passed.
I really appreciate your if you can review the updated codes.

[starpit]

@hirokuni-kitahara can you rebase (other PRs have also changed the schema) and then run npm run types in pdl-live-react? this will re-generate the typescript types in accordance with the changes to the schema. thanks!

[mandel]

Thank you that is a great feature!

Instead of doing it only on repeat blocks, what about adding this field in the Block class inherited by all the blocks?

I would also rename retry_max simply into retry.

[hirokuni-kitahara]

@starpit @mandel
Thank you very much for your feedbacks!
Yes, I will rebase and update ts with the command, and also I will add just retry to the Block class.

[hirokuni-kitahara]

Hi @vazirim @mandel @starpit,
the retry feature is ready now and I think I already updated all the related files (including the schema.json and ts file).
Could you please review the changes? Thank you!

[vazirim]

Thank you very much for the changes @hirokuni-kitahara!

LGTM

@mandel @starpit any more feedback?

[starpit]

does this handle the case where an async/future'd model block invocation fails?