Skip to content

Redirect /about to /resources #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Redirect /about to /resources #1774

wants to merge 1 commit into from

Conversation

roshni73
Copy link
Collaborator

@roshni73 roshni73 commented Apr 4, 2025 •
edited by samshara
Loading

Addresses

Changes

  • Redirect /about to /resources

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • No console.log statements meant for debugging
  • All CI checks have passed

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: bfbd13a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@roshni73 roshni73 requested a review from barshathakuri April 4, 2025 08:37
samshara
samshara requested changes Apr 7, 2025
View reviewed changes
app/src/App/routes/index.tsx
Comment on lines +1178 to +1191
const aboutRedirect = customWrapRoute({
parent: rootLayout,
path: '/about',
component: {
render: () => import('#views/Resources'),
props: {},
},
wrapperComponent: Auth,
context: {
title: 'Resources',
visibility: 'anything',
},
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not render Resources page directly, we should use Navigate component to route to the resources page.
For example, https://github.com/IFRCGo/go-web-app/blob/6d755498fa096679ebd817fdb1efe9d7e94a2398/app/src/App/routes/index.tsx#L1178C1-L1193C4

@samshara samshara changed the title add about redirects Redirect /about/ to /resources Apr 7, 2025
@samshara samshara changed the title Redirect /about/ to /resources Redirect /about to /resources Apr 7, 2025
@frozenhelium frozenhelium marked this pull request as draft April 28, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samshara samshara samshara requested changes

@barshathakuri barshathakuri Awaiting requested review from barshathakuri

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roshni73 @samshara