Skip to content

ENH: Updates for ITK 5.4.0 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Jun 5, 2024

Update CI to build against v5.4.0

Also, improve how the itk python package version dependency is
specified. Uses == 5.4.* to indicated compatibility with 5.4.0, 5.4.1,
5.4.2, etc., but not 5.5.0, etc. There is generally binary
incompatibilty between minor versions. While it is possible that there
could be binary incompatibility between patch releases, it is more
likely that they will be compatible. This flexibilty helps ensure
that remote module packages are not assumed invalid when a new patch
version of itk is released. Addresses #142

Update CI to build against v5.4.0

Also, improve how the `itk` python package version dependency is
specified. Uses `== 5.4.*` to indicated compatibility with 5.4.0, 5.4.1,
5.4.2, etc., but not 5.5.0, etc. There is generally binary
incompatibilty between minor versions. While it is possible that there
could be binary incompatibility between patch releases, it is more
likely that they will be compatible. This flexibilty helps ensure
that remote module packages are not assumed invalid when a new patch
version of `itk` is released. Addresses InsightSoftwareConsortium#142
@thewtex
Copy link
Member Author

thewtex commented Jun 5, 2024

@dyollb @SimonRit please take a look

Copy link

@SimonRit SimonRit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I would suggest using a more recent tag for itk-python-package-tag.

@thewtex thewtex merged commit 0d54bc7 into InsightSoftwareConsortium:main Jun 10, 2024
17 checks passed
@thewtex thewtex deleted the itk-5.4.0 branch June 10, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants