Skip to content

simplify backend implementation of dpnp.kaiser #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

simplify backend implementation of dpnp.kaiser #2472

wants to merge 2 commits into from

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jun 6, 2025 •
edited
Loading

This PR simplifies backend implementation of dpnp.kaiser by getting rid of unnecessary template and address some technical debt.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Jun 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

View rendered docs @ https://intelpython.github.io/dpnp/pull/2472/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2025 •
edited
Loading

Coverage Status

coverage: 71.764% (+0.001%) from 71.763%
when pulling 7518f2d on simplify-kaiser
into 662148d on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_8 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

@vtavana vtavana marked this pull request as ready for review June 6, 2025 01:28
antonwolfy
antonwolfy approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jun 6, 2025
@vtavana vtavana requested a review from antonwolfy June 6, 2025 17:44
@vtavana vtavana force-pushed the simplify-kaiser branch from 788c35e to 7518f2d Compare June 6, 2025 17:53
@vtavana vtavana force-pushed the simplify-kaiser branch from 7518f2d to ba80a1f Compare June 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy