GDD: trigger chain selection when caught-up #1505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Genesis is disable statically, we never even schedule any LoE reprocessing, so this doesn't change anything in this situation. When Genesis is disabled and we are caught-up, then there are concrete scenarios where we want to reprocess LoE blocks, see the preceding two commits.
amesgen
requested review from
jasagredo,
fraser-iohk,
dnadales,
geo2a and
jorisdral
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1503
The first commit adds a regression test, which is then fixed by the second and third commit in this PR. Reverting either commit makes the regression test fail as expected.