TX Submission Logic #4887
Open
TX Submission Logic #4887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
coot
force-pushed
the
coot/tx-submission
branch
6 times, most recently
from
76c0d13 to
11d833b
Compare
This was referenced Sep 18, 2024
crocodile-dentist
force-pushed
the
coot/tx-submission
branch
2 times, most recently
from
772809e to
374a78a
Compare
coot
force-pushed
the
coot/tx-submission
branch
from
374a78a to
388cc69
Compare
coot
force-pushed
the
coot/tx-submission
branch
from
efbc13a to
7b8ec92
Compare
coot
force-pushed
the
coot/tx-submission
branch
from
7b8ec92 to
22c71d5
Compare
coot
force-pushed
the
coot/tx-submission
branch
from
22c71d5 to
6a1bdd9
Compare
coot
force-pushed
the
coot/tx-submission
branch
2 times, most recently
from
974b98d to
a764ad1
Compare
coot
force-pushed
the
coot/tx-submission
branch
6 times, most recently
from
adae14f to
3258afe
Compare
karknu
reviewed
Mar 14, 2025
ouroboros-network/src/Ouroboros/Network/TxSubmission/Inbound/State.hs
Outdated
Show resolved
Hide resolved
coot
force-pushed
the
coot/tx-submission
branch
from
3258afe to
1d40e61
Compare
Add the time it took to add TXs to the mempool to the TxInboundAddedToMempool tracer.
DeltaQ metrics is only available for our warm and hot peers that also have us as hot. So a fraction of all downstream clients will have a metric. This change the ranking of peers to use simple scoring system. Deliver a new TX before in time before it gets into the block gives you one point. Delivering a TXs thats already in the mempool, is invalid, or fail because it was included in a recent blocks gives you a penalty. Only the peer's that downloaded a TX will attempt to add it to the mempool
It is using a single map lookup instead of two.
We don't need to compute `max 0` twice, since the inputs are always non-negative (e.g. `n ≥ 0`) and thus `drained + n ≥ 0`.
Just to make it more outstanding what the output of `acknowledgeTxIds` is indented for.
Removed `withMempoolSem` and added instead `addTxToMempool`.
Renamed the `EnableNewTxSubmissionProtocol` type to `TxSubmissionLogicVersion` and moved it to `V2.Types`
Export all functions & supporting types.
The flag enables an initial 60s delay on the inbound side in the same way as for in the V1 version.
* `ctrl-<addr>` - the control thread
(top level threads, e.g. [2], [3], etc..)
* `node-<addr>` - the main node thread
([2,1], [3,1], etc)
* `krnl-<addr>` - the kernel thread (block production)
Removed the `TurbulentCommands` generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a draft PR (work in progress) which introduces
tx-submissionlogic responsible for choosing from which peer to download a tx.Checklist
Quality
Maintenance
ouroboros-networkproject.