Migrate from OSSRH to Sonatype Central publishing #915
+58
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmethvin
force-pushed
the
sonatype-publish
branch
3 times, most recently
from
1f75ce6 to
893fd68
Compare
Ayyanchira
approved these changes
Jun 24, 2025
gmethvin
force-pushed
the
sonatype-publish
branch
5 times, most recently
from
6e20733 to
633e1f7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Android SDK publishing pipeline by migrating from the legacy OSSRH plugin to Sonatype Central via the NMCP Gradle plugin, updating CI steps, and cleaning up deprecated logic.
- Switches
maven-push.gradleto usecom.gradleup.nmcpwith property-based credentials and automatic publishing - Always applies the shared publishing script in both
iterableapianditerableapi-uimodules - Updates the GitHub Actions workflow to import GPG keys, generate a secret ring, and publish through Sonatype Central
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| maven-push.gradle | Replaced manual OSSRH repo setup with NMCP plugin and property lookups |
| iterableapi/build.gradle | Removed conditional guard around apply from: '../maven-push.gradle' |
| iterableapi-ui/build.gradle | Same unconditional apply of publishing script |
| .github/workflows/publish.yml | Renamed workflow, added branch filter, revamped GPG import/publish steps |
| .editorconfig | Added YAML file indentation rules |
Comments suppressed due to low confidence (2)
.github/workflows/publish.yml:8
- GitHub Actions tag filters use glob patterns, not regex. The
+quantifier won’t work here. Consider a glob like"[0-9]*.[0-9]*.[0-9]*"or explicit patterns to match version tags.
- "[0-9]+.[0-9]+.[0-9]+*" # Match version tags like 3.5.13, 3.6.0-beta1, etc.
iterableapi/build.gradle:94
- [nitpick] Removing the
hasProperty("mavenPublishEnabled")guard means the publishing script always loads, which may break local or test builds when credentials are missing. Consider reintroducing a feature flag or graceful no-op handling.
apply from: '../maven-push.gradle'
633e1f7 to
122b010
Compare
Ayyanchira
reviewed
Jun 25, 2025
gmethvin
force-pushed
the
sonatype-publish
branch
from
122b010 to
4ac7d8c
Compare
Ayyanchira
reviewed
Jun 25, 2025
| cache: gradle | ||
|
|
||
| - name: Import GPG Key | ||
| - name: Import GPG Key and Create Secring |
Ayyanchira
approved these changes
Jun 25, 2025
|
|
||
| - name: Build | ||
| run: ./gradlew clean build | ||
| - name: Build and Publish to Sonatype Central |
There was a problem hiding this comment.
Very well and clearly named 👍🏼
| @@ -16,50 +16,42 @@ | |||
|
|
|||
| apply plugin: 'maven-publish' | |||
| apply plugin: 'signing' | |||
| apply plugin: 'com.gradleup.nmcp' | |||
There was a problem hiding this comment.
Wow, so existing maven-push injection will still work as is with now new plugin. 👌🏼
gmethvin
force-pushed
the
sonatype-publish
branch
2 times, most recently
from
8fcc497 to
46985c3
Compare
- Switch to gradleup/nmcp plugin for automatic publication - Update GitHub Actions to use SONATYPE_USERNAME/SONATYPE_PASSWORD - Remove manual repository configuration and staging steps - Configure modern GPG signing using global iterable secrets
gmethvin
force-pushed
the
sonatype-publish
branch
from
46985c3 to
f760be3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
N/A
✏️ Description
Migrates Android SDK publishing from legacy OSSRH to the new Sonatype Central publishing system using the NMCP plugin. This includes:
The migration maintains backward compatibility while modernizing the publishing infrastructure.