Skip to content

chore: dedup methods #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+1,633 −250
Draft

chore: dedup methods #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
426 changes: 213 additions & 213 deletions .yarn/releases/yarn-3.6.1.cjs → .yarn/releases/yarn-3.6.4.cjs
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
nodeLinker: node-modules
nmHoistingLimits: workspaces

nodeLinker: node-modules

plugins:
- path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
spec: "@yarnpkg/plugin-interactive-tools"
- path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
spec: "@yarnpkg/plugin-workspace-tools"

yarnPath: .yarn/releases/yarn-3.6.1.cjs
yarnPath: .yarn/releases/yarn-3.6.4.cjs
1 change: 1 addition & 0 deletions AppLibTest
Open in desktop
Submodule AppLibTest added at c51a43
34 changes: 17 additions & 17 deletions android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,12 @@ public void initializeWithApiKey(String apiKey, ReadableMap configReadableMap, S
promise.resolve(true);
}

@ReactMethod
public void setEmail(@Nullable String email) {
IterableLogger.d(TAG, "setEmail: " + email);
IterableApi.getInstance().setEmail(email);
}
// @ReactMethod
// public void setEmail(@Nullable String email) {
// IterableLogger.d(TAG, "setEmail: " + email);

// IterableApi.getInstance().setEmail(email);
// }

@ReactMethod
public void setEmail(@Nullable String email, @Nullable String authToken) {
Expand All @@ -120,12 +120,12 @@ public void setEmail(@Nullable String email, @Nullable String authToken) {
IterableApi.getInstance().setEmail(email, authToken);
}

@ReactMethod
public void updateEmail(String email) {
IterableLogger.d(TAG, "updateEmail: " + email);
// @ReactMethod
// public void updateEmail(String email) {
// IterableLogger.d(TAG, "updateEmail: " + email);

IterableApi.getInstance().updateEmail(email);
}
// IterableApi.getInstance().updateEmail(email);
// }

@ReactMethod
public void updateEmail(String email, @Nullable String authToken) {
Expand All @@ -145,16 +145,16 @@ public void sampleMethod(String stringArgument, int numberArgument, Callback cal
callback.invoke("Received numberArgument: " + numberArgument + " stringArgument: " + stringArgument);
}

@ReactMethod
public void setUserId(@Nullable String userId) {
IterableLogger.d(TAG, "setUserId: " + userId);
IterableApi.getInstance().setUserId(userId);
}
// @ReactMethod
// public void setUserId(@Nullable String userId) {
// IterableLogger.d(TAG, "setUserId: " + userId);
// IterableApi.getInstance().setUserId(userId);
// }

@ReactMethod
public void setUserId(@Nullable String userId, @Nullable String authToken) {
IterableLogger.d(TAG, "setUserId: " + userId + " authToken: " + authToken);

IterableApi.getInstance().setUserId(userId, authToken);
}

Expand Down
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@iterable/react-native-sdk",
"version": "2.0.0",
"version": "111111112.0.0-interop-rc.4",
"description": "Iterable SDK for React Native.",
"source": "./src/index.tsx",
"main": "./lib/module/index.js",
Expand Down Expand Up @@ -117,9 +117,10 @@
},
"sideEffects": false,
"workspaces": [
"example"
"example",
"AppLibTest"
],
"packageManager": "[email protected].1",
"packageManager": "[email protected].4",
"commitlint": {
"extends": [
"@commitlint/config-conventional"
Expand Down
2 changes: 1 addition & 1 deletion src/itblBuildInfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
* It contains the version of the package
*/
export const buildInfo = {
version: '2.0.0',
version: '111111112.0.0-interop-rc.4',
};
Loading
Loading