-
Notifications
You must be signed in to change notification settings - Fork 36
[MOB-11436] Android: add serialization of placements #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: evan/embedded-message-class
Are you sure you want to change the base?
Changes from all commits
a591d39
5366d3a
a546287
aac04d5
a6efa27
38eddb9
6f1c83d
c35774b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
import { NativeModules } from 'react-native'; | ||
|
||
import { Iterable } from '../../core/classes/Iterable'; | ||
import { IterableEmbeddedPlacement } from './IterableEmbeddedPlacement'; | ||
import type { IterableEmbeddedMessage } from './IterableEmbeddedMessage'; | ||
|
||
const RNIterableAPI = NativeModules.RNIterableAPI; | ||
|
||
|
@@ -14,11 +14,14 @@ export class IterableEmbeddedManager { | |
/** | ||
* Retrieve the current user's list of embedded placements. | ||
* | ||
* @param {number} placementId The ID of the placement to retrieve messages from. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tsdoc-param-tag-with-invalid-type: The @param block should not include a JSDoc-style '{type}' [eslint:tsdoc/syntax] There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tsdoc-param-tag-with-invalid-type: The @param block should not include a JSDoc-style '{type}' [eslint:tsdoc/syntax] |
||
* @returns A Promise that resolves to an array of embedded placements. | ||
*/ | ||
getPlacements(): Promise<IterableEmbeddedPlacement[]> { | ||
Iterable?.logger?.log('EmbeddedManager.getPlacements'); | ||
getMessages(placementId: number): Promise<IterableEmbeddedMessage[]> { | ||
Iterable?.logger?.log( | ||
`EmbeddedManager.getMessages for placement ${placementId}` | ||
); | ||
|
||
return RNIterableAPI.getEmbeddedPlacements(); | ||
return RNIterableAPI.getEmbeddedMessages(placementId); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tsdoc-param-tag-with-invalid-type: The @param block should not include a JSDoc-style '{type}' [eslint:tsdoc/syntax]