-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Disable test not working on Windows #12869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
void tearDown() { | ||
this.indexer.closeAndWait(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tearDown method is unnecessary when using @tempdir, as JUnit automatically handles cleanup of temporary directories. This violates the instruction to avoid redundant cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The indexer locks the directory!
Together with #12868, maybe we can get rid of this one? |
Yes, there is a lot of overlap right now between the bot texts and FAQ page. |
@trag-bot didn't find any issues in the code! ✅✨ |
The build of this PR is available at https://builds.jabref.org/pull/12869/merge. |
What is the status here? |
Someone needs to go through the failing tests and decide whether they should be fixed or if it can be disabled. I plan to do it as soon as I find time. |
Pull request was converted to draft
With this PR, all tests in
:test
should work on WindowMandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)