[JEWEL-803] Replace get() with safer getOrNull() in ThemeColorPalette #3015
+48
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamen
force-pushed
the
hamen/JEWEL-803
branch
2 times, most recently
from
fee1820 to
5e9a18a
Compare
rock3r
reviewed
Apr 2, 2025
.../samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Borders.kt
Outdated
Show resolved
Hide resolved
.../samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Borders.kt
Outdated
Show resolved
Hide resolved
...mples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Scrollbars.kt
Outdated
Show resolved
Hide resolved
...mples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Scrollbars.kt
Outdated
Show resolved
Hide resolved
.../samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Borders.kt
Outdated
Show resolved
Hide resolved
...el/samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Icons.kt
Outdated
Show resolved
Hide resolved
...mples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Scrollbars.kt
Outdated
Show resolved
Hide resolved
rock3r
reviewed
Apr 2, 2025
...el/samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Icons.kt
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an unfortunate lack of warning for methods that can throw exceptions.
ThemeColorPalettewas using a nullable chain containing alsoget(index)and then acting on missing values using the Elvis operator.?. Unfortunately,get(index)is an unsafe method that throws, preventing the.?from doing any rescue.We switched to a safer variant, and properly managing the
null.