-
Notifications
You must be signed in to change notification settings - Fork 44
Replace src/scitypes.jl with ScientificTypes.jl package #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasjfk minor
…se.jl into tablescitype
This was referenced Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first three changes below resolve MLJ issue #176
(breaking for model implementations) Replace the model trait
input_scitype_union
withinput_scitype
. It's value is now some scitype defined by the new ScientificTypes package, egTable(Continuous)
(instead ofContinuous
) so that non-tabular data can be supported. See ScientificTypes documentation for more on the Table scientific type.(breaking for model implementations) Replace the model trait
target_scitype_union
withscitype_union
with similar remarks applying.(breaking for model implementations) Eliminate
target_is_multivariate
andinput_is_multivariate
traits as this information is now implicit in value of above revamped traits(breaking) Eliminate
scitypes
method. The scientific types of a table are returned as part of ScientificTypesschema
method, which is re-exported by MLJBase. (MLJBase.schema
used to coincide withTables.schema
.)add
package_license_trait
(fallback value is "unknown")add
supports_weights
trait for measures and modelsEfficiency and other improvements to UnivariateFinite distribution (resolves Use LittleDicts in UnivariateFinite? #22), including implementation of
Distributions.support
. This is different fromclasses
which returns all categorial values for the distribution, not just those with non-zero probability. This is breaking becauseclasses
used to return whatsupport
does now.Address DataFrames depreciation warning due to column access change in its API
(breaking) CSV is now an optional dependency, which means you now need to import CSV before you can load tasks with
load_boston()
,load_iris()
,load_crabs()
,load_ames()
,load_reduced_ames()
. Addresses Implement the MLJ model API without needing to depend on external dependencies such as CSV.jl, CategoricalArrays.jl, etc. #19