Skip to content

Replace src/scitypes.jl with ScientificTypes.jl package #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Aug 19, 2019
Merged

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Aug 19, 2019

The first three changes below resolve MLJ issue #176

  • (breaking for model implementations) Replace the model trait input_scitype_union with input_scitype. It's value is now some scitype defined by the new ScientificTypes package, eg Table(Continuous) (instead of Continuous) so that non-tabular data can be supported. See ScientificTypes documentation for more on the Table scientific type.

  • (breaking for model implementations) Replace the model trait target_scitype_union with scitype_union with similar remarks applying.

  • (breaking for model implementations) Eliminate target_is_multivariate and input_is_multivariate traits as this information is now implicit in value of above revamped traits

  • (breaking) Eliminate scitypes method. The scientific types of a table are returned as part of ScientificTypes schema method, which is re-exported by MLJBase. (MLJBase.schema used to coincide with Tables.schema.)

  • add package_license_trait (fallback value is "unknown")

  • add supports_weights trait for measures and models

  • Efficiency and other improvements to UnivariateFinite distribution (resolves Use LittleDicts in UnivariateFinite? #22), including implementation of Distributions.support. This is different from classes which returns all categorial values for the distribution, not just those with non-zero probability. This is breaking because classes used to return what support does now.

  • Address DataFrames depreciation warning due to column access change in its API

  • (breaking) CSV is now an optional dependency, which means you now need to import CSV before you can load tasks with load_boston(), load_iris(), load_crabs(), load_ames(), load_reduced_ames(). Addresses Implement the MLJ model API without needing to depend on external dependencies such as CSV.jl, CategoricalArrays.jl, etc. #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use LittleDicts in UnivariateFinite? Flaw in the use of input_scitype_union, and so forth
1 participant