Skip to content

Standardizer is unreasonably slow for large tables #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ablaom opened this issue Sep 23, 2019 · 1 comment
Closed

Standardizer is unreasonably slow for large tables #63

ablaom opened this issue Sep 23, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@ablaom
Copy link
Member

ablaom commented Sep 23, 2019

I'm pretty sure the reason for the slowdown in the current implementation is a problem with computing scitypes of large arrays - ScientificTypes #12.

The table scitype is computed both in the machine constructor (which checks compatibility of any input table with the model requirement) and in the fit method. There is no obvious workaround in the first case, but in the second we could just infer what we need from the column eltypes.
@ablaom ablaom added the enhancement New feature or request label Sep 23, 2019
@tlienart tlienart mentioned this issue Sep 26, 2019
Merged
@ablaom ablaom mentioned this issue Sep 27, 2019
Closed
@ablaom ablaom mentioned this issue Oct 16, 2019
Closed
@ablaom
Copy link
Member Author

ablaom commented Oct 17, 2019

Resolved.

@ablaom ablaom closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ablaom