Migration, standardizer and a few fixes #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well this was surprisingly difficult...
what's in this PR
primary
@mlj_model
etc) reference: todo Towards 0.5.0 #62MLJBase.schema
byTables.schema
including inStandardizer
which now looks at the machine type instead of the scitype reference: todo Towards 0.5.0 #62 . We can revert this in the future whenscitype(X)
is slow for large tables ScientificTypes.jl#12 is solved but in the mean time I would strongly prefer it stayed the way it is. ImportantlyContinuous
while suggesting that it could be applied onCount
(it should) and while theUnivariateStandardizer
could be applied on all RealUnivariateStandardizer
works.Note: closes #63 , also supersedes #69
secondary
Transformers
somewhat as well as their testsAMBIGUOUS_NAMES
etc using the usualconst
trickNote on meta tools
The tools
@mlj_model
andmetadata_*
cannot be used reliably for builtin models (src/builtins/Constant
andsrc/builtins/Transformers
). This causes no other problem than irritation, I tried, multiple ways and ended up wasting a fair bit of time; all ways failed, either complaining about theeval
in a closed package MLJBase or that things get re-defined. None of these issues arise when using the tools in interfaces.So in short: use the old approach for anything built-in.