Skip to content

Improve performance of scitype on arrays in the mlj convention (resolves #12) #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2019

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Oct 16, 2019

#12

@codecov-io
Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #23 into dev will decrease coverage by 2.35%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev     #23      +/-   ##
=========================================
- Coverage   95.45%   93.1%   -2.36%     
=========================================
  Files           7       7              
  Lines         132     145      +13     
=========================================
+ Hits          126     135       +9     
- Misses          6      10       +4
Impacted Files Coverage Δ
src/conventions/mlj/images.jl 100% <ø> (ø) ⬆️
src/ScientificTypes.jl 97.29% <ø> (ø) ⬆️
src/conventions/mlj/mlj.jl 85.71% <0%> (-14.29%) ⬇️
src/conventions/mlj/finite.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ffed04...68ac89f. Read the comment docs.

This was referenced Oct 16, 2019
@ablaom ablaom merged commit 10c0578 into dev Oct 16, 2019
@ablaom ablaom deleted the fix-slow branch October 16, 2019 22:37
juliohm pushed a commit to juliohm/ScientificTypes.jl that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants