Skip to content

Support for general index types #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 16, 2020
Merged

Support for general index types #27

merged 11 commits into from
Mar 16, 2020

Conversation

dlfivefifty
Copy link
Member

This is to support multi-dimensional bases

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #27 into master will increase coverage by 3.02%.
The diff coverage is 68.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   34.71%   37.74%   +3.02%     
==========================================
  Files          17       17              
  Lines        1230     1224       -6     
==========================================
+ Hits          427      462      +35     
+ Misses        803      762      -41
Impacted Files Coverage Δ
src/QuasiArrays.jl 46.66% <ø> (ø) ⬆️
src/quasiarray.jl 93.1% <100%> (ø) ⬆️
src/abstractquasiarray.jl 34.24% <50%> (+2.53%) ⬆️
src/multidimensional.jl 17.24% <56.25%> (-0.64%) ⬇️
src/subquasiarray.jl 48.79% <72.88%> (+16.36%) ⬆️
src/quasibroadcast.jl 45.58% <75%> (ø) ⬆️
src/indices.jl 42.85% <82.35%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbdb01d...e86c7d3. Read the comment docs.

@dlfivefifty dlfivefifty changed the title WIP support for general index types Support for general index types Mar 16, 2020
@dlfivefifty
Copy link
Member Author

@jagot This will likely be merged soon. It will make it possible to do multidimensional bases, e.g., I'm planning to create a SphericalHarmonics.jl package building on this

@jagot
Copy link
Member

jagot commented Mar 16, 2020

Cool! I would be interested in how this would work out for vector-valued functions, i.e. for problems of the kind discussed here: JuliaApproximation/ContinuumArrays.jl#15 (comment)

@dlfivefifty
Copy link
Member Author

The failed tests are due to Travis

@dlfivefifty dlfivefifty merged commit 378e4bb into master Mar 16, 2020
@dlfivefifty dlfivefifty deleted the dl/generalinds branch March 16, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants