Skip to content

repeat for AbstractFill #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2023
Merged

repeat for AbstractFill #242

merged 4 commits into from
May 24, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented May 5, 2023

Fix #175

After this

julia> repeat(Trues(2,3), 2,3)
4×9 Ones{Bool}

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #242 (acc59a4) into master (ec975cd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   99.73%   99.74%           
=======================================
  Files           5        5           
  Lines         754      775   +21     
=======================================
+ Hits          752      773   +21     
  Misses          2        2           
Impacted Files Coverage Δ
src/FillArrays.jl 99.43% <100.00%> (+0.03%) ⬆️
src/fillbroadcast.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty
Copy link
Member

Bump to 1.1 as it introduces a near feature

@dlfivefifty
Copy link
Member

Can you get the coverage back up? (It was 100% at one point)

@jishnub jishnub mentioned this pull request May 16, 2023
@jishnub
Copy link
Member Author

jishnub commented May 16, 2023

I think #248 should help with this, so I can rebase this PR once that's merged

@jishnub
Copy link
Member Author

jishnub commented May 16, 2023

Coverage seems fixed now

@dlfivefifty dlfivefifty merged commit c9d7d98 into JuliaArrays:master May 24, 2023
@jishnub jishnub deleted the repeat branch May 24, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specialize repeat(::Fill)
2 participants