Ensure static array constructors create copies #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
+ Coverage 93.28% 93.36% +0.07%
==========================================
Files 37 37
Lines 2710 2711 +1
==========================================
+ Hits 2528 2531 +3
+ Misses 182 180 -2
Continue to review full report at Codecov.
|
|
Maybe a test that the |
|
Sounds like a good idea. I added that test as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether I've missed anything here, but calling
Tupleseems like the simplest way to achieve a copying constructor.Fixes #335
The second commit here is a quick fix for some broken constructors I found when creating a test case for this.