Remove is(abstract|bits)type functions #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelHatherly
approved these changes
Jun 8, 2021
|
Thanks @MichaelHatherly. I'll bump the version right here and will merge and tag as soon as the tests pass again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
JuliaLang/julia#41018JuliaLang/julia#40741 removed the.abstractfield fromDataType, so DocStringExtensions is currently broken on nightly because of that. But I think the localisabstracttypeandisbitstypedefinitions are some pre-1.0 leftovers -- functions with the same name are available in Base -- so it should be safe to just remove them.ismutabletypewas added in 1.7 (JuliaLang/julia#39037), so we need a local version of it if it is not defined inBase.