Skip to content

fix mapreducedim<bang> ambiguities with Adjoint, Transpose, PermutedDimsArray #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix mapreducedim<bang> ambiguities with Adjoint, Transpose, PermutedDimsArray #522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
300cf50
fix mapreducedim<bang> ambiguities with Adjoint, Transpose, PermutedD…
vpuri3 Mar 6, 2024
1ed28b1
Merge branch 'master' into mapreducedim
vpuri3 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/host/mapreduce.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,30 @@ mapreducedim!(f, op, R::AnyGPUArray, A::AbstractArrayOrBroadcasted;
Base.mapreducedim!(f, op, R::AnyGPUArray, A::AbstractArray) = mapreducedim!(f, op, R, A)
Base.mapreducedim!(f, op, R::AnyGPUArray, A::Broadcast.Broadcasted) = mapreducedim!(f, op, R, A)

# resolve ambiguities with Adjoint/Transpose
# https://github.com/JuliaLang/julia/blob/master/stdlib/LinearAlgebra/src/adjtrans.jl#L440-L448
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these commit-stable links, e.g., https://github.com/JuliaLang/julia/blob/4dcf35786ec164832e1eb961c9cdacae7974a27a/stdlib/LinearAlgebra/src/adjtrans.jl#L440-L448

Base.mapreducedim!(f, op::LinearAlgebra.CommutativeOps, B::AnyGPUArray, A::LinearAlgebra.TransposeAbsMat) =
(Base.mapreducedim!(f∘transpose, op, LinearAlgebra.switch_dim12(B), parent(A)); B)
Base.mapreducedim!(f, op::LinearAlgebra.CommutativeOps, B::AnyGPUArray, A::LinearAlgebra.AdjointAbsMat) =
(Base.mapreducedim!(f∘adjoint, op, LinearAlgebra.switch_dim12(B), parent(A)); B)
Base.mapreducedim!(f::typeof(identity), op::Union{typeof(*),typeof(Base.mul_prod)}, B::AnyGPUArray, A::LinearAlgebra.TransposeAbsMat{<:Union{Real,Complex}}) =
(Base.mapreducedim!(f∘transpose, op, LinearAlgebra.switch_dim12(B), parent(A)); B)
Base.mapreducedim!(f::typeof(identity), op::Union{typeof(*),typeof(Base.mul_prod)}, B::AnyGPUArray, A::LinearAlgebra.AdjointAbsMat{<:Union{Real,Complex}}) =
(Base.mapreducedim!(f∘adjoint, op, LinearAlgebra.switch_dim12(B), parent(A)); B)

# resolve ambiguities with PermutedDimsArray
# https://github.com/JuliaLang/julia/blob/master/base/permuteddimsarray.jl#L355-L364
function Base.mapreducedim!(f, op::LinearAlgebra.CommutativeOps, B::AnyGPUArray{T,N}, A::PermutedDimsArray{S,N,perm,iperm}) where {T,S,N,perm,iperm}
C = PermutedDimsArray{T,N,iperm,perm,typeof(B)}(B) # make the inverse permutation for the output
Base.mapreducedim!(f, op, C, parent(A))
B
end
function Base.mapreducedim!(f::typeof(identity), op::Union{typeof(Base.mul_prod),typeof(*)}, B::AnyGPUArray{T,N}, A::PermutedDimsArray{<:Union{Real,Complex},N,perm,iperm}) where {T,N,perm,iperm}
C = PermutedDimsArray{T,N,iperm,perm,typeof(B)}(B) # make the inverse permutation for the output
Base.mapreducedim!(f, op, C, parent(A))
B
end

neutral_element(op, T) =
error("""GPUArrays.jl needs to know the neutral element for your operator `$op`.
Please pass it as an explicit argument to `GPUArrays.mapreducedim!`,
Expand Down