place cursor, GdkRGBA that works with tag, expanded constructor of di… #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splay rgba and replaced deprecated calls to bool() with calls to Bool()
| @@ -16,7 +16,7 @@ convert{U<:Unsigned}(::Type{U},x::RGB) = convert(U,(x.r)|(x.g>>8)|(x.b>>16)) | |||
|
|
|||
| immutable RGBA | |||
| r::UInt8; g::UInt8; b::UInt8; a::UInt8 | |||
| RGBA(r,g,b) = new(r,g,b) | |||
| RGBA(r,g,b,a) = new(r,g,b,q) | |||
|
Thanks, this looks right to me. I didn't realize that they were exposing different primitive types. Can you get CI passing and then I can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't merge the RGBA and GdkRGBA because the rgba values were of different primitive types. I also couldn't figure out how to expose GdkRGBA analogous to for instance @TextBuffer, so now it can be accessed with Gtk.GdkRGBA.