delete _rand_pm1! in favor of rand!

Author: rfourquet

base/sparse/linalg.jl

@@ -622,7 +622,7 @@ function normestinv(A::SparseMatrixCSC{T}, t::Integer = min(2,maximum(size(A))))
     X[1:n,1] = 1
     for j = 2:t
         while true
-            _rand_pm1!(view(X,1:n,j))
+            rand!(view(X,1:n,j), (-1, 1))
             yaux = X[1:n,j]' * X[1:n,1:j-1]
             if !_any_abs_eq(yaux,n)
                 break
@@ -683,7 +683,7 @@ function normestinv(A::SparseMatrixCSC{T}, t::Integer = min(2,maximum(size(A))))
                         end
                     end
                     if repeated
-                        _rand_pm1!(view(S,1:n,j))
+                        rand!(view(S,1:n,j), (-1, 1))
                     else
                         break
                     end

base/sparse/sparse.jl

@@ -27,7 +27,7 @@ import Base: @get!, acos, acosd, acot, acotd, acsch, asech, asin, asind, asinh,
     vcat, hcat, hvcat, cat, imag, indmax, ishermitian, kron, length, log, log1p, max, min,
     maximum, minimum, norm, one, promote_eltype, real, reshape, rot180,
     rotl90, rotr90, round, scale!, setindex!, similar, size, transpose, tril,
-    triu, vec, permute!, map, map!, Array, _rand_pm1!
+    triu, vec, permute!, map, map!, Array
 
 export AbstractSparseArray, AbstractSparseMatrix, AbstractSparseVector,
     SparseMatrixCSC, SparseVector, blkdiag, droptol!, dropzeros!, dropzeros,

base/sysimg.jl

@@ -441,8 +441,6 @@ include("pkg/pkg.jl")
 
 # sparse matrices, vectors, and sparse linear algebra
 
-function _rand_pm1! end # defined in Random
-
 include("sparse/sparse.jl")
 using .SparseArrays
 

stdlib/Random/src/sparse.jl

@@ -144,12 +144,3 @@ sprand(::Type{T}, n::Integer, p::AbstractFloat) where {T} = sprand(defaultRNG(),
 
 sprandn(n::Integer, p::AbstractFloat) = sprand(defaultRNG(), n, p, randn)
 sprandn(r::AbstractRNG, n::Integer, p::AbstractFloat) = sprand(r, n, p, randn)
-
-
-## _rand_pm1! (used in Base.LinAlg)
-
-function Base._rand_pm1!(v)
-    for i in eachindex(v)
-        v[i] = rand(Bool) ? 1 : -1
-    end
-end