RFC: create an extra slot for arguments that get assigned #16410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. needs rebase. |
It simplifies later analysis to assume that arguments are not overwritten. This could simplify codegen a bit more in the future, but for now we are generating stack slots for arguments anyway, for debug info.
|
Thanks for the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the idea in #16159 (comment). With this, we can assume arguments are not assigned, and the
assignedvarinfo flag is no longer needed. This brings us tantalizingly close to not needing var flags at all. This will also allow us to remove linfo.specTypes as discussed in #16159.