Fix MethodError printing in case of ambiguity #17008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,7 +116,7 @@ function showerror(io::IO, ex::MethodError) | |||
| f = ex.f | |||
| meth = methods_including_ambiguous(f, arg_types) | |||
| if length(meth) > 1 | |||
| return showerror_ambiguous(io, meth, f, arg_types) | |||
| return showerror_ambiguous(io, map(x->x[3], meth), f, arg_types) | |||
There was a problem hiding this comment.
@JeffBezanson, or would you rather change this in methods_including_ambiguous?
There was a problem hiding this comment.
Yes, I guess it would be best for that function to return the same kind of result as methods.
JeffBezanson
force-pushed
the
teh/ambig_printing
branch
from
b6abc50 to
877e3d7
Compare
JeffBezanson
force-pushed
the
teh/ambig_printing
branch
from
877e3d7 to
fd90163
Compare
JeffBezanson
force-pushed
the
teh/ambig_printing
branch
from
fd90163 to
111d72a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17007.