Add tests for #20103 #21358
Merged
Add tests for #20103 #21358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis 64bit linux timed out (10 minutes without output), so probably a test hanging, but |
musm
reviewed
Apr 12, 2017
test/subtype.jl
Outdated
| @@ -1070,3 +1070,12 @@ end | |||
| @testintersect(Tuple{A20992{R, D, d} where d where D, Int} where R, | |||
| Tuple{C20992{S, n, T, D, d} where d where D where T where n where S, Any}, | |||
| Tuple{C20992, Int}) | |||
|
|
|||
| # issue #20103, OP and comments | |||
| immutable TT20103{X,Y} end | |||
test/subtype.jl
Outdated
| immutable TT20103{X,Y} end | ||
| f20103{X,Y}(::Type{TT20103{X,Y}},x::X,y::Y) = 1 | ||
| f20103{X}(::Type{TT20103{X,X}},x::X) = 100 | ||
| @testintersect(Tuple{Int, Ref{Pair{K,V}}} where V where K, |
There was a problem hiding this comment.
This test already appears on line 834.
There was a problem hiding this comment.
ah, thanks for pointing that out
martinholters
force-pushed
the
mh/test_20103
branch
from
e7a09a4 to
6638d93
Compare
|
Comments addressed. |
|
AppVeyor failure unrelated ( |
martinholters
force-pushed
the
mh/test_20103
branch
from
6638d93 to
c691234
Compare
|
Ok, this time I think I actually have addressed the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although not everything is perfect with all the comments in #20103, most of them (and the OP) have been fixed eventually, so I'd say this closes #20103.