Skip to content

[release-0.6] fix #22164 and #22002, method sorting problems #22206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2017
Merged

[release-0.6] fix #22164 and #22002, method sorting problems #22206

merged 1 commit into from
Jun 5, 2017

Conversation

JeffBezanson
Copy link
Member

This is a minimal version of #22162 that fixes these two bugs, which seem fairly important. Hence I've opened this against release-0.6.

@tkelman tkelman changed the base branch from release-0.6 to tk/backports-0.6.0-rc3 June 3, 2017 21:33
@tkelman
Copy link
Contributor

tkelman commented Jun 3, 2017

changed the base branch to #22199 so I don't have to rebase that

@tkelman
Copy link
Contributor

tkelman commented Jun 3, 2017

if this is an exact cherry pick of 8b83fa7 and partial backport of #22162, would be good to cross reference that fact in the commit message

@JeffBezanson
Copy link
Member Author

It's not a cherry pick, but I guess it qualifies as a partial backport.

@tkelman
Copy link
Contributor

tkelman commented Jun 3, 2017

patch looks the same to me, other than the tests going in a different file?

@tkelman tkelman force-pushed the tk/backports-0.6.0-rc3 branch from ea1cc8f to ac35d0f Compare June 3, 2017 23:34
@tkelman tkelman changed the title fix #22164 and #22002, method sorting problems [release-0.6] fix #22164 and #22002, method sorting problems Jun 5, 2017
@JeffBezanson @tkelman
fix #22164 and #22002, method sorting problems
56b68d9 
fix #22164, specificity issue in ForwardDiff

(cherry picked from commit e92eb58)
partial backport of #22162
@tkelman tkelman merged commit 567488c into tk/backports-0.6.0-rc3 Jun 5, 2017
@tkelman tkelman deleted the jb/fix22002 branch June 5, 2017 23:36
@JeffBezanson JeffBezanson mentioned this pull request Jun 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffBezanson @tkelman