Skip to content

[release-0.6] fix assertion when loading ColorVectorSpace on release-0.6 #22386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2017

Conversation

JeffBezanson
Copy link
Member

Currently, if you do using ColorVectorSpace on a debug build of release-0.6 you get an assertion failure.
This is a backport of #22162 that fixes the problem.

@tkelman
Copy link
Contributor

tkelman commented Jun 15, 2017

add a reference to the PR number in the commit messages

simplify tuple type specificity implementation

fix specificity `A{B,B,C} < A{B,C,D}`

Backported from PR #22162

(cherry picked from commit 4634a3d)

Conflicts:
	test/core.jl
Backported from PR #22343

(cherry picked from commit bd2dcf1)

Conflicts:
	test/specificity.jl
@JeffBezanson JeffBezanson force-pushed the jb/release-0.6-specificity branch from ca8dcba to 25d8c3a Compare June 15, 2017 22:22
@JeffBezanson
Copy link
Member Author

Done.

@tkelman tkelman changed the title fix assertion when loading ColorVectorSpace on release-0.6 [release-0.6] fix assertion when loading ColorVectorSpace on release-0.6 Jun 16, 2017
@tkelman
Copy link
Contributor

tkelman commented Jun 17, 2017

assuming this is go for 0.6.0 if pkgeval looks good on it?

(I'll change the target branch if so)

@tkelman tkelman changed the base branch from release-0.6 to tk/backports-0.6.0 June 17, 2017 01:29
@tkelman tkelman merged commit eafaae7 into tk/backports-0.6.0 Jun 17, 2017
@tkelman tkelman deleted the jb/release-0.6-specificity branch June 17, 2017 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants