more performant SparseMatricCSC constructors for structured matrices #32492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #32466, implementing what was suggested here #10843 (comment). I was experimenting with all kinds of high-level things, like
repeat
, andcollect
of ranges etc., but nothing was working as fast with as little allocations as simply fillingundef
ined vectors of appropriate type (especiallyrepeat
was really bad!). Some benchmarks are below. The call tosparse
corresponds to the current master code (i.e., "before PR"), the calls toSparseMatrixCSC
call functions of this PR ("with PR"). For larger sizes the gain can be a factor larger than 10.