-
Notifications
You must be signed in to change notification settings - Fork 10
Code clean-up #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code clean-up #105
Conversation
Codecov ReportBase: 85.11% // Head: 84.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 85.11% 84.85% -0.26%
==========================================
Files 10 10
Lines 1632 1637 +5
==========================================
Hits 1389 1389
- Misses 243 248 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Codecov ReportBase: 85.24% // Head: 85.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 85.24% 85.34% +0.10%
==========================================
Files 10 10
Lines 1633 1638 +5
==========================================
+ Hits 1392 1398 +6
+ Misses 241 240 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This is a companion PR to JuliaLang/julia#46196, in case that one gets accepted. This will fail on nightly before that LinearAlgebra PR gets merged.I have removed theAdjointQ
stuff and left the pure code clean-up part. I carefully reviewed which functions are actually overloaded (hence need to beimport
ed) and which ones are onlyuse
d. I also removed obsolete package specifiers and added a few factorizationldiv!
s to make the package proof for some work inLinearAlgebra.jl
.