RFC: make FillArrays.jl a weakdep #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
==========================================
- Coverage 87.08% 87.04% -0.05%
==========================================
Files 10 11 +1
Lines 1773 1775 +2
==========================================
+ Hits 1544 1545 +1
- Misses 229 230 +1
☔ View full report in Codecov by Sentry. |
|
I pushed things a bit further. Controversial aspects are the above-mentionen |
dkarrasch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as far as I got. I got stuck at the
MulAdd(::Mul)constructor, which callsmulzeros, which callsZerosforNumbereltypes. So, either this means we have a strong dependency, or there is a work-around. Perhaps, after JuliaArrays/FillArrays.jl#286 FillArrays.jl is light enough anyway, but if there is a simple enough work-around, I think it would be still beneficial to reduce strong dependencies as much as possible. I'm leaving for summer holidays, so I'm putting this up for comments.