Skip to content

Fix banded-diagonal Lmul/Rmul copy #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Fix banded-diagonal Lmul/Rmul copy #255

merged 3 commits into from
Feb 19, 2025

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Feb 19, 2025

This works around the missing convert methods to Bidiagonal/Tridiagonal, and fixes the failing tests on nightly

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.53%. Comparing base (0690818) to head (abdb8b9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/diagonal.jl 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   89.58%   89.53%   -0.05%     
==========================================
  Files          11       11              
  Lines        1930     1940      +10     
==========================================
+ Hits         1729     1737       +8     
- Misses        201      203       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub
Copy link
Member Author

jishnub commented Feb 19, 2025

Missing coverage seems spurious, as the added lines are definitely being tested. Commenting them out causes the tests to fail.

@jishnub jishnub merged commit a5b61f2 into master Feb 19, 2025
16 of 18 checks passed
@jishnub jishnub deleted the jishnub/diaglrmulcopy branch February 19, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant