Skip to content

Use indices instead of stride in default_blasmul #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 16, 2025

There's no need to use linear indexing here, since the conversion from Cartesian to linear is cheap.

Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (b9b424e) to head (49140ea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   89.52%   89.51%   -0.02%     
==========================================
  Files          11       11              
  Lines        1938     1936       -2     
==========================================
- Hits         1735     1733       -2     
  Misses        203      203              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit 752510c into master Mar 16, 2025
17 checks passed
@jishnub jishnub deleted the jishnub/defblasmul_stride branch March 16, 2025 11:50
@dlfivefifty
Copy link
Member

How do you know it’s cheap?

@jishnub
Copy link
Member Author

jishnub commented Mar 16, 2025

In most cases, accessing memory will be significantly more expensive than integer multiplication and addition. In any case, this change is unnecessary, so I'm reverting this in #260.

@dlfivefifty
Copy link
Member

Please don't merge changes like this without review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants