R2N & R2DH : add sigma and sigma_cauchy entry to stats #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
==========================================
- Coverage 61.53% 59.55% -1.98%
==========================================
Files 11 15 +4
Lines 1292 1894 +602
==========================================
+ Hits 795 1128 +333
- Misses 497 766 +269 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Here are the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added more information in the R2N so that the user can read more things from the execution of R2N.
I added the sigma entry as for R2.
I added the sigma_cauchy entry that is the regularization parameter used for computing the Cauchy step (which actually the regularization parameter i am interested in when I use R2N as a subsolver)
Can you please review when you have some time available @dpo ?
Thank you !